Eric Jolibois comments

Results 115 comments of


                                            Eric Jolibois

Implement multiple header_rows

Hello @deanm0000 @lukapeschke and I are considering adding this to v0.12.0 Do you have a MRE with an excel file + expected output? Thanks

docs: add required `LLMConfig` for Azure OpenAI

I have read the CLA Document and I hereby sign the CLA

29.02 cell cast to 29.020000000000003 string

Hello @severinh Always great to have a clear bug issue with file and clear explanation thank you! I checked quickly and indeed it feels hard to fix on `fastexcel` side...

29.02 cell cast to 29.020000000000003 string

Thanks @jmcnamara indeed it's really in the xml content itself. Maybe we could use `rust_decimal` crate that implements already a "smart" `Display` With ```toml [dependencies] rust_decimal = { version =...

29.02 cell cast to 29.020000000000003 string

Again thank you for the info. Much appreciated. I reckon we should make a PR on calamine side. I can maybe do that this weekend

29.02 cell cast to 29.020000000000003 string

We chose to support it directly in fastexcel for now. It should have very little impact because it's only applied for float to string conversion

Coercing dates to strings adds time of the form '00:00:00'

Yup the issue is that it's detected as `datetime` by calamine. We can try to do a `as_date()` afterwards but it would be better if calamine could handle directly dates....

Option to exclude `model_extra` from `repr`

My comment is not against you but more a general opinion. I didn't say you added a lot of parameters, I just said you added one more and I feel...

`use_columns` silently skips empty columns at the beginning

Yes the engine behind fastexcel `calamine` skips empty columns by default. I plan to add an option on `calamine` directly like I did for skipping empty rows

feat: add option to keep first empty rows for xlsx

I'll try to tackle other file formats by the end of the week