Eric Jolibois comments

Results 115 comments of


                                            Eric Jolibois

feat: add option to keep first empty rows for xlsx

@tafia I added the support for ODS. I reckon having the option at workbook level is not appropriate. We could want to open a sheet with one header row and...

feat: add option to keep first empty rows for xlsx

@ACronje yup!

feat: add option to keep first empty rows for xlsx

The rust part is not really a problem and I can finish the job easily, it's more a problem of API ;) I need @tafia opinion on https://github.com/tafia/calamine/pull/453#issuecomment-2358655100

feat: add option to keep first empty rows for xlsx

I first went with the `with_options` approach (it's still the case in this PR) but I reckon it's wrong to have sheet options (like `header_row`) that are meant for a...

feat: add option to keep first empty rows for xlsx

Thanks for sharing your opinion. I'll finish implementing all the extensions and let the `with_options` for now. If it's good enough it will be mergeable directly. If not it won't...

feat: add option to keep first empty rows for xlsx

Ok @tafia sorry for those last changes but I prefer switching to an enum. It's more explicit and I plan on adding `skip_rows` and `n_rows` to options after. So I...

Strange failure to determine `string` dtype column in ODS sheet/file

Ok I looked into it ### success.ods ```rs &range = Range { start: ( 0, 0, ), end: ( 12, 0, ), inner: [ String( "StringCol", ), String( "bbb", ),...

Strange failure to determine `string` dtype column in ODS sheet/file

calamine 0.26 has been released and added in fastexcel Release 0.12.0 of fastexcel will fix this issue. I plan to release it this week

Strange failure to determine `string` dtype column in ODS sheet/file

v0.12.0 is out

Error reading ods file with read_ods

Hey! I'll look into it over the next few days 👍