Eric Jolibois

Results 115 comments of Eric Jolibois

@aiguofer With #2625, this is what you get ```py class UserCreatedEvent(Event): """ specific event type that only uses the standardized event fields """ name = "user-created" source_name = "my-app" @field...

What would you want ? ```py @field(type=User) ``` ?

> There should also be some simple way to to set the dump alias to "skip" or "exclude" which means that field is excluded when calling `dict()` or `json()`. @samuelcolvin...

Added the "breaking change" mention and a note in the doc Hope it's clear enough

I would close as much as possible and avoid a breaking change

> the env_prefix for secrets, which doesn't make sense and is very confusing. I still agree with myself 😄 If we can change this in v2, that will be great!...

Hi @vnmabus How about ```py lit = Literal["ward", "complete", "average", "single"] lit2 = Literal[tuple(x.value for x in LinkageCriterion.__members__.values())] assert lit == lit2 ``` Hope it helps

Duplicate of https://github.com/PRQL/prql/issues/993 and fixed in https://github.com/PRQL/prql/pull/3883

I guess it could be done if we set `Config.underscore_attrs_are_private = True` by default in v2 (see https://github.com/samuelcolvin/pydantic/discussions/2471). If set to `False` we could accept all names (so make `is_valid_field`...

I'm on holiday starting tomorrow. My plan is to finally take some time to work on those issues.