Eric Jolibois comments

Results 115 comments of


                                            Eric Jolibois

Document that recursive models will make a copy of instances passed into a constructor by default?

@goodboy PR welcome to add a "info" or "warning" section

Add ability to have custom encoder for builtin types

I guess it also tackles #3104?

Add ability to have custom encoder for builtin types

Hmmm I'm not sure. Clearly it's something that I want and that should be added in pydantic but I would have waited for v2.

fix: using constraints in generics no longer raises ValueError (#2581, #3358)

@samuelcolvin Honestly I don't know. One thing I'm sure about, I'll personally put a lot of efforts on v2 to make generics work properly. And leaving cython will help a...

The big Onion

First and foremost thank you for this clear and explicit proposal! Onion ring model is the reason I switched from [express](https://github.com/expressjs/express) to [koa](https://github.com/koajs/koa) on an old project: writing custom middleware...

Custom validator does not include Enum fields in 'values' argument

You mean change from `str` to `E1AdhrMessageType`?

Allow for passing keyword arguments to from_orm

> they would understandably find it pretty annoying if this PR gets closed now. computed fields PR will probably be closed so trust me I know the feeling 😆 but...

Incorrect schema generation, conflict with python-jsonschema

Yep nullable in generated json schema is not properly handled. It'll be there in v1.10 or v2

Incorrect schema generation, conflict with python-jsonschema

https://github.com/samuelcolvin/pydantic/pull/1611

Serializing @property

Hey people! I started https://github.com/samuelcolvin/pydantic/pull/2625 since I also would really like this for one project. Feedback more than welcome on the API and the missing features before I write more...