Paul Berg

Results 724 comments of Paul Berg

> The name is not related to Etherscan Actually, it's _also_ related to Etherscan. The NFT collection has to be manually listed (which is what I did a while ago)....

Do you mean include `open-ended` in the repo currently called `v2-core`?

Got it. I need to review `open-ended` before I am able to properly comment on this. But my instinct is to keep them separated.

The jury is still out if it will be separate. But let's go with `LockupNFTDescriptor` for now.

I suggest renaming this repo to `lockup` instead of creating a separate one. The rationale is thus: - We would lose the 310+ stars - We would lose the connectivity...

Agree that we should document this as an assumption, but there should be no need for exponents that large. When you get that to double-digit ranges and above, the streaming...

@smol-ninja @andreivladbrg let's not forget about this before handing off the final commit to Rusty

Thank you very much @smol-ninja. As discussed previously, we will review and merge this PR after the private audit is finished.

Can we please switch to Bulloak in the next release, or at least do it in `open-ended`? Reviewing PRs that modify BTs without Bulloak is a **pain**