Paul Berg comments

Results 723 comments of


                                            Paul Berg

Bug, or clarification needed around `forge install`, and the lib folder

Also, I recommend against using git submodules: https://twitter.com/PaulRBerg/status/1736694426578137247

Feature request: add a tag for the unit test coverage approach

unfortunately not able to reviesw this proposal at this time, tagging @andreivladbrg and @smol-ninja in case they want to contribute.

Feature request: `bulloak.toml` config file

> I know people have hated having way-too-many config files historically, but I don't really mind it. Me neither! > `bulloak` is already coupled to Foundry, however, that might change...

Feature request: GPT integration to shorten function and modifier names

Another very interesting application of GPT would be to use it to write the tests themselves - not just scaffold the skeleton Solidity file.

Feature request: special naming for the final leaf test

A corollary of this feature (if it gets implemented) is that the `check` command would have to be adjusted to accept both possible names, i.e. - `test_WhenXIsTrue` - `test_SimpleBranch`

Use `try...catch` in `cancelMultiple` and `withdrawMultiple` to handle invalid stream IDs

LGTM except for the error name. I would create two errors, one for withdrawals, and another for cancellations. I'd also say something like `InvalidWithdrawalInBatch`

Use `try...catch` in `cancelMultiple` and `withdrawMultiple` to handle invalid stream IDs

@smol-ninja could you please create a milestone for the next Lockup release, and include this issue in that milestone? And let's name it according to the package tethering approach.

Use `try...catch` in `cancelMultiple` and `withdrawMultiple` to handle invalid stream IDs

Sorry, I meant a board. The name sounds good.

Use `try...catch` in `cancelMultiple` and `withdrawMultiple` to handle invalid stream IDs

This feature would mitigate [L-07. WithdrawMultiple can be DOS'ed by a random user](https://www.codehawks.com/report/clvb9njmy00012dqjyaavpl44#L-07) from the CodeHawk report, wouldn't it?

Use `try...catch` in `cancelMultiple` and `withdrawMultiple` to handle invalid stream IDs

Thanks for looking into this, Shub! We don't allow hook calls when the recipient makes the withdrawal because they are redundant. The recipient knows that they made the withdrawal, so...