Paul Berg comments

Results 723 comments of


                                            Paul Berg

Use `try...catch` in `cancelMultiple` and `withdrawMultiple` to handle invalid stream IDs

> reentrancy issues?🤔 Reentrancy is an issue only if CEI is not respected.

Use `try...catch` in `cancelMultiple` and `withdrawMultiple` to handle invalid stream IDs

Thanks Shub, good work so far. I pushed a commit to improve the writing in #1101. However, I'm against the PR as it currently stands because it introduces a new,...

Research on re-writing some functions in Yul to optimize for gas

Yul typically impairs the readability of the code, but I'm happy to give this idea a go (and see some optimization proposals). Anyway - I'd classify this as `effort: epic`.

Exclude clickjacking in security disclosure

No, I have updated the OP with the correct URL, thanks @andreivladbrg

Package tethering

Yep. That's why I've marked it as `effort: epic`.

Package tethering

Oh shoot, you're right @andreivladbrg. The repo should be renamed to `evm-lockup` or `sablier-lockup`. I would go with the latter, though I'm on the fence about it. Which one do...

Package tethering

That's a good point, @smol-ninja, but after more rumination on this, I think we should go with `evm-lockup`. 1. Even if type-3/4 zkEVMs are not full-blown EVMs, they are still...

Package tethering

> we should remove "V2" from the contracts yeah, that should be another issue > one other thing bad with the sablier-lockup name is that it would be redundant to...

Another implication of PacTet is that we will have to update the name of our NFT collections on Etherscan. For instance, [this collection](https://etherscan.io/token/0xb10daee1fcf62243ae27776d7a92d39dc8740f95) should be renamed from "Sablier V2 Lockup...