Paul Berg comments

Results 723 comments of


                                            Paul Berg

PRBMath SD59x18 and UD60x18 properties

Guys just wanted to say that unfortunately I am tied up with my work (on Sablier V2), and I cannot find any time to provide a proper review here. I'm...

Show unmet peer dependencies on `bun install <package>`

This would be really helpful! I was debugging an ugly ESM error, and the culprit was an uninstalled peer dependency. I found out by going back to Yarn.

bug(forge): empty if/else statements are not covered

Makes sense!

feat(`cheatcodes`): add ability to exclude certain custom errors and revert reason strings from failing tests

@emo-eth I have. I think this is what I was trying to get at with the OP — reverts due to USDC blacklisted addresses should be ignored.

feat(`cheatcodes`): add ability to exclude certain custom errors and revert reason strings from failing tests

I don't think I have.

feat(`cheatcodes`): add ability to exclude certain custom errors and revert reason strings from failing tests

looks good for me, tagging for @andreivladbrg and @smol-ninja for additional feedback

Add `[profile.default.coverage]` section to `foundry.toml`

If this something like gets implemented, it should be just a table/ section in the Foundry config, e.g. `[profile.default.coverage]`, analogous to `[profile.default.fuzz]`.

feat(forge): disable coverage for assertions

Also if [FREI-PI](https://www.nascent.xyz/idea/youre-writing-require-statements-wrong) picks up steam, assertions' coverage will become an even bigger problem.

Incorrect test contract names when sharing tests in gas snapshot

I will try to reproduce this.

Incorrect test contract names when sharing tests in gas snapshot

@grandizzy it was this repo though I can't remember the exact commit where this happened https://github.com/sablier-labs/v2-core