Patrick Collins comments

Results 248 comments of


                                            Patrick Collins

Gas estimation failed

The kovan addresses have changed a lot... It's likely due to a new address. Maybe we should update the repo to stick to mainnet-forks and not testnets? What do you...

The updated config file wouldn't compile unless I changed the compiler to 8.1 and commented out the private keys.

Could you make this in a pull request? 🙏

The updated config file wouldn't compile unless I changed the compiler to 8.1 and commented out the private keys.

I'll leave this issue open if anyone else ran into it

Error: cannot estimate gas; transaction may fail or may require manual gas limit

There is a good chance this is just too big :/ Could you test deploying an NFT with that much data on something like Remix?

Importing interfaces not as docs describe

Got it. We should probably update the docs to be more clear - been slamming my head.

Decentralized Exchanges and Aggregators like uniswap, dex.blue, and 1inch.exchange

If there is a huge push, I can set up something simple for this. I've got a few python scripts myself that already do the job. I'm a bit swamped...

forge audit to check/list all ffi usage

Bump

Make a doc that has the solidity style guide + the Chainlink style guide

Probably the chainlink core repo. https://github.com/smartcontractkit/chainlink I'd like someone from the Chainlink Labs org to do it though, to make sure the style is correct.

Make a doc that has the solidity style guide + the Chainlink style guide

Sure!

The links in the main Readme.md should open in the new tab.

I don't think so, you can CMD + Click or CTRL + Click to open in new tab. Might be good feedback though... @krakxn what do you think?