full-blockchain-solidity-course-js icon indicating copy to clipboard operation
full-blockchain-solidity-course-js copied to clipboard

Published 20 hours ago • verified publisher icon smartcontractkit

Make a doc that has the solidity style guide + the Chainlink style guide

Open PatrickAlphaC opened this issue 2 years ago • 5 comments

Describe the enhancement

Make a PR to the chainlink github with the style guide officially laid out.

PatrickAlphaC avatar May 24 '22 17:05 PatrickAlphaC

How's this #434 ? Let me know if that needs some improvements or if you were thinking of something different altogether.

Also let me know if it's better I make a new PR since #434 is a bit of a mess. It has multiple commits cause I kept fixing the formatting. And it also has a typo fix for README.md

joonakauranen avatar Jun 21 '22 18:06 joonakauranen

Does this still have to be done? If so, where in Chainlink's GitHub should the PR be made? Cheers.

krakxn avatar Jul 06 '22 01:07 krakxn

Probably the chainlink core repo.

https://github.com/smartcontractkit/chainlink

I'd like someone from the Chainlink Labs org to do it though, to make sure the style is correct.

PatrickAlphaC avatar Jul 06 '22 02:07 PatrickAlphaC

Probably the chainlink core repo.

https://github.com/smartcontractkit/chainlink

I'd like someone from the Chainlink Labs org to do it though, to make sure the style is correct.

I see! Is it okay if I do one myself and make a PR there? Because that way, if necessary, it will be easier for someone from Chainlink Labs to verify/edit the guide. Cheers.

krakxn avatar Jul 06 '22 17:07 krakxn

Sure!

PatrickAlphaC avatar Jul 06 '22 21:07 PatrickAlphaC