full-blockchain-solidity-course-js icon indicating copy to clipboard operation
full-blockchain-solidity-course-js copied to clipboard

The links in the main Readme.md should open in the new tab.

Open adityabhattad2021 opened this issue 1 year ago • 4 comments

Describe the enhancement

In the main readme.md of this repository when we click on the link in gets opened in the same tab which makes it difficult to continuously refer to repository and the given material.

adityabhattad2021 avatar Jul 21 '22 00:07 adityabhattad2021

You can right-click on the links>Open in new tab

krakxn avatar Jul 21 '22 11:07 krakxn

@PatrickAlphaC Do you think is relevant? If so, I can change the README.md to account for the changes (anchor tags/links to open in a new tab) necessary via HTML.

krakxn avatar Sep 15 '22 04:09 krakxn

I don't think so, you can CMD + Click or CTRL + Click to open in new tab.

Might be good feedback though... @krakxn what do you think?

PatrickAlphaC avatar Sep 15 '22 16:09 PatrickAlphaC

@PatrickAlphaC Personally, I am used to manually opening in new tabs as well.

I do think it would be a good addition though; occasionally, on misclicking and opening in the same tab, I would have to find the section I was in if Chrome did not save the fragment (i.e. hashtag "#xyz123" part of the URL).

The changes can be done so by using target=_blank in the anchor links.

From Mozilla docs, browser support for the same:

image

(The "NOs" are for Opera and Android WebView--I suppose it opens in the same tab for them)

If needed, I can make a PR w/ the changes.

krakxn avatar Sep 16 '22 11:09 krakxn