code-owner-self-merge

code-owner-self-merge copied to clipboard

Support auto-merge from "lgtm" with a way to cancel it

3

* https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-auto-merge-for-pull-requests-in-your-repository * https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/incorporating-changes-from-a-pull-request/automatically-merging-a-pull-request This way I don't have to wait until the test succeeds.

saschanaz

Fails to merge from a review comment

3

It seems a review comment has no permission to do a merge?

saschanaz

Convert `lgtm` to a command-like word

2

Because a comment like "lgtm but..." accidentally causes a merge. 😬

saschanaz

Allow JSON files (e.g. package.json) to be partially modifiable by codeowners

1

something like: ``` packages.json#devDependencies @saschanaz ``` Dependency updates can be easier this way.

saschanaz

Merge on test finish if the approval happened earlier

2

Not sure how without searching all comments 🤔

saschanaz

orta

Self merge does not work with branch protection

2

Hi, When setting `Require pull request reviews before merging` + `Require review from Code Owners` within the repo's branch protection rules, the action fails with the comment "There was an...

dudicoco

Action doesn't work for organization teams

2

Hey there, this is a super useful plugin! However, it doesn't seem to work with the `@org/team-name` syntax as specified in the [CODEOWNERS spec](https://docs.github.com/en/free-pro-team@latest/github/creating-cloning-and-archiving-repositories/about-code-owners#codeowners-syntax). It seems like the `codeowners` npm...

erickzhao

Crash when commenting/merging

1

In https://github.com/microsoft/TypeScript-Website/pull/978 - [here](https://github.com/microsoft/TypeScript-Website/pull/978/checks?check_run_id=1257687413#step:3:7) ``` Looking at the pull_request_review from sasurau4 in 'Translate 3 tsconfig files to ja' to see if we can merge Changed files: - /packages/tsconfig-reference/copy/ja/categories/Watch_Options_999.md - /packages/tsconfig-reference/copy/ja/intro.md...

orta

Codeowner crash

1

This is before we even do any work ``` (node:3743) UnhandledPromiseRejectionWarning: TypeError [ERR_INVALID_ARG_TYPE]: The "path" argument must be of type string. Received type object 8 at validateString (internal/validators.js:112:11) 9 at...

orta