Matt O'Keefe

Results 11 comments of Matt O'Keefe

I pulled the repo and was able to successfully run `npm test` could you expand on which tests you see broken?

I see a bunch of failed tests now, however, this PR ^ is needed before running them is "easy" ;)

> Hi @kirjs, > Looks like I worked on some tests which are already done in #1176. @Mutmatt, can you tell me if there are any tests remaining which need...

> wow, this looks awesome! > > Curious if you were in touch with @hansal7014 (from #1136) to avoid duplicate work? Did not, i must have started before those comments...

> Ok, cool, good to know, I pinged the other thread to avoid doing the same stuff twice in the future, for now let's merge this in I'm pulled the...

Hey @NothingEverHappens this was not blocked just haven't had a time to get back to the enormity of this. This in and of itself should be ok if we wanted...

> After lots of testing I reached the limit of free certbot certificates. I'm now sharing the certificate via a volume between Swag and Mailu nginx and this seems to...

This is more specific to the github API than the specific action. If you are still working on getting this one maybe check out these docs: https://docs.github.com/en/developers/webhooks-and-events/events/github-event-types#pullrequestevent https://docs.github.com/en/rest/pulls/pulls?apiVersion=2022-11-28#list-commits-on-a-pull-request Seems the...

Any chance we could get 👀 on this. looks like this will solve #142 and #141