codelab icon indicating copy to clipboard operation
codelab copied to clipboard

Fix tests

Open NothingEverHappens opened this issue 4 years ago • 3 comments

What the issue is about

Some of ur tests are broken. We want to fix all of them and start running them in CI

You don't need to fix all tests

Even fixing one would be a nice start

How to start

run npm run affected:test to see what's broken

NothingEverHappens avatar Oct 08 '19 14:10 NothingEverHappens

I pulled the repo and was able to successfully run npm test could you expand on which tests you see broken?

O-Mutt avatar Oct 18 '19 17:10 O-Mutt

@Mutmatt Ah, good catch, there are multiple projects, and looks like tests have been fixed for the main one.

Can you try running npm run affected:test on a clean repo and let me know if this works?

NothingEverHappens avatar Oct 18 '19 17:10 NothingEverHappens

I see a bunch of failed tests now, however, this PR ^ is needed before running them is "easy" ;)

O-Mutt avatar Oct 18 '19 21:10 O-Mutt