codelab
codelab copied to clipboard
codelab-fun
Massive Refactor for jest testing
This modifies all the tests to run under jest. There are a lot of broken tests still.
Ref: #1136 #1137
wow, this looks awesome!
Curious if you were in touch with @hansal7014 (from #1136) to avoid duplicate work?
wow, this looks awesome!
Curious if you were in touch with @hansal7014 (from #1136) to avoid duplicate work?
Did not, i must have started before those comments came in. It took me a few days of messing around to get everything working well enough
Ok, cool, good to know, I pinged the other thread to avoid doing the same stuff twice in the future, for now let's merge this in
Ok, cool, good to know, I pinged the other thread to avoid doing the same stuff twice in the future, for now let's merge this in
I'm pulled the travis changes because there are still a ton of broken tests.
Just wanted to send a friendly ping to understand the state of this and make sure it's not blocked from our side.
Hey @NothingEverHappens this was not blocked just haven't had a time to get back to the enormity of this. This in and of itself should be ok if we wanted to take a small chunk out of the project
Cool, would you have some time to address the feedback? (I think it's mostly dropping unused code bytes, and other small things)?
I think this is a big step forward compered to what we have now and would be awesome to get merged.
Hey @Mutmatt, are you planning to look into merging this in? Or alternatively I can work on doing this.