Tobias Nyholm

Results 325 comments of Tobias Nyholm

What if we collect exceptions and then if no result we throw either: 1) one exception if `count($exceptions) === 1` 2) A `new ChainExceptionCollection($exceptions)` We do someting similar in Symfony/messanger.

We should not throw exception if we get a result. They should only be thrown if no result was found. I like the idea of getting exceptions throw a getter...

No it wouldn’t. The contract is from the interface. The interface states that an exception might be thrown, right?

Yes. Because if one package breaks BC the main build will be red. It is fine that one package breaks BC (it might prepare for a new major release) but...

I dont think we can add a `UnsupportedOperation` . That would violate Liskov substitution principle. I think we should create a new interface for this new feature (instead of modifying...

Thank you for this PR. I cannot remember the reason why that function was not a part of the interface. Maybe we considered it unnecessary. I cannot merge this PR...

I think you are correct. Is that how other providers do?

Oh, Hm. So the cache store empty responses **if** there is a chain and you got some exceptions, is that correct? I believe it is always valid to store empty...

I really think it is an issue so I will not close it. Im not a super fan of doing a workaround the problem. I would be much happier trying...

Could you please update the test to show that it is broken? https://github.com/brefphp/extra-php-extensions/blob/master/layers/imagick/test.php