Geocoder icon indicating copy to clipboard operation
Geocoder copied to clipboard

Published 20 hours ago • verified publisher icon geocoder-php

Add Query::withText

Open mbrodala opened this issue 6 years ago • 2 comments

This was missing in #743 and is essential for mocking in tests.

mbrodala avatar Mar 02 '18 15:03 mbrodala

Thank you for this PR. I cannot remember the reason why that function was not a part of the interface. Maybe we considered it unnecessary.

I cannot merge this PR now since it would be a BC break. I will put it to the v5 milestone. (But do not hold your breath about v5 to be released... sorry)

Nyholm avatar Mar 02 '18 15:03 Nyholm

Sure, I understand. I'll try to figure out a working test setup.

mbrodala avatar Mar 02 '18 15:03 mbrodala