Geocoder icon indicating copy to clipboard operation
Geocoder copied to clipboard

Feat #942 implement provider lookup method

Open franzwilding opened this issue 5 years ago • 3 comments

franzwilding avatar Jul 02 '19 15:07 franzwilding

If you need any help getting this done let me know @franzwilding :)

atymic avatar Aug 14 '19 02:08 atymic

We indeed need to update all the providers and add an UnsupportedOperation on the lookupQuery for those who do not support this operation (just like reverseQuery in AlgoliaPlaces , for instance)

jbelien avatar Aug 14 '19 13:08 jbelien

I dont think we can add a UnsupportedOperation . That would violate Liskov substitution principle.

I think we should create a new interface for this new feature (instead of modifying Geocoder). Then maybe a new trait (instead of modifying GeocoderTrait).

That will make it easy to add to providers one by one. (Or just the one we like). It will also avoid breaking BC.

Nyholm avatar Aug 14 '19 13:08 Nyholm

was this ever pushed?

mrelliot69 avatar Sep 30 '22 22:09 mrelliot69

was this ever pushed?

No, we are still waiting for an update from the author.

jbelien avatar Oct 01 '22 08:10 jbelien