Tobias Nyholm
Tobias Nyholm
Try use prettier 2.8.8 instead of 3.0
Thank you @acasademont for taking time to review this. I have now rebased the code. What do you think about using the twig environment instead of injecting the `RequestStack`?
I've updated this PR. It supports SF2.3 and the tests are fixed. @acasademont, is this ready to be merged?
Thank you @XWB for your feedback. I had not considered the scenario where you do not use all locales. I have rewritten the PR according to your comments.
Thank you for this issue. Would you mind providing a PR with a test case that reveals this bug?
Again, Please send a PR so we can fix this problem for everyone.
> i would put them in a 3rd section "Client Decorators" I agree.
Consider using this geocoder instead: https://github.com/geocoder-php/Geocoder If you really really need a provider in this repo, please consider porting it to https://github.com/geocoder-php/Geocoder or install a `egeloen/http-adapter`
That is awesome. Make a pull request and we can work together. It does not matter if the code is not perfect or if the tests does run at first.
I keep mine on the same line. There is a PR that will make sure we support concatenating strings but it needs some updates from the author before it can...