NullVoxPopuli comments

Results 2059 comments of


                                            NullVoxPopuli

Remove `escapeExpression` from `@ember/template`

> May have been private but Handlebars.Utils.escapeExpression has uses in addons... people using private apis should be used to what happens? :sweat_smile: :upside_down_face: idk, what's the process here? do we...

Remove `escapeExpression` from `@ember/template`

I've now rebased this PR, as I forgot about it :sweat_smile:

[bugfix] allow `modifier` helper to resolve built-ins like `on`

Why does ember have its own record of this stuff? I would have thought this behavior (and fix) would be in glimmer-vm, since `modifier` is a keyword.

[bugfix] allow `modifier` helper to resolve built-ins like `on`

that's goofy. I wonder if we can instead do all the resolution at build time instead of runtime. I feel like I have either a very faint memory, or I...

[Bug] `#in-element` cannot directly render in to shadow-dom

Repro: https://github.com/NullVoxPopuli/ember-source-5.6-broke-shadow-dom (check commits)

[Bug] `#in-element` cannot directly render in to shadow-dom

I have a hunch this has to do with Glimmer-vm changes :thinking:

Perf: Bugfix: Don't read before write for anything with a descriptor

I don't know what the impact of this PR is, as I have no clue about the older get/set patterns anymore. (I jumped on tracked when 3.13 was canary). Can...

Ember.A should not modify underlying array

can this be rebasod?

[FEATURE] Add template tag component blueprints via --strict flag as per RFC #779

very excited for this!

WIP: Keep a record of stale owners to help better debug poor test isolation

in ember-qunit, we can pre-wire that in a [QUnit.startStart](https://api.qunitjs.com/callbacks/QUnit.testStart/) hook. The code in this PR will need to be resilient to a test-adapter forgetting / opting out of "container test-reporting"...