ember.js icon indicating copy to clipboard operation
ember.js copied to clipboard
verified publisher icon emberjs

Perf: Bugfix: Don't read before write for anything with a descriptor

Open runspired opened this issue 4 years ago • 4 comments

Mostly opening this to see what tests fail. Currently when using set or EmberObject.set ember will first read a prop before writing to it unless that property happens to have a COMPUTED_SETTER which is only true for things that utilized tracked or computed. This causes performance issues and bugs when read before write is not expected.

runspired avatar Apr 23 '21 00:04 runspired

It's something I feel we should change but it doesn't seem we have a clear path to changing it. Wouldn't might the thoughts of @pzuraq

runspired avatar May 24 '21 16:05 runspired

Is this still relevant? It is a draft PR

kategengler avatar Dec 12 '23 16:12 kategengler

its relevant until starbeam, though I'm not sure what the path forward is. @NullVoxPopuli may have a better idea he's been poking around those parts

runspired avatar Dec 14 '23 23:12 runspired

I don't know what the impact of this PR is, as I have no clue about the older get/set patterns anymore. (I jumped on tracked when 3.13 was canary).

Can you rebase?

NullVoxPopuli avatar Dec 14 '23 23:12 NullVoxPopuli