NullVoxPopuli
NullVoxPopuli
This also seems related: https://github.com/ember-intl/ember-intl/issues/1826 except this crashes the app.
Gonna close this since the package is now a v2 addon! thanks @vlascik your work inspired the work that did landed!
> As far as I can tell the addon is still in JS. Yes, but everything has type declarations now! 🎉
https://github.com/adopted-ember-addons/ember-cli-flash/blob/master/ember-cli-flash/src/test-support.js does it make sense to make this automatic at all? rather than manually invoked?
Oh ok, thanks for the link!
> These configurations are the main reason I think this addon should go away yeah, with just this config, I'm not confident that the mirage assets are excluded from the...
actually, reading through the code, it seems `enabled` might not do what I want? in that it's not used in the `treeFor*` hooks?: https://github.com/miragejs/ember-cli-mirage/blob/master/packages/ember-cli-mirage/index.js#L111 Reading the docs, it looks like...
> Mirage is based on pretender, in case you werent aware though oh I am. I hate pretender. lol. It's such a DX travesty. 🙃
I just booted my app trying to disable mirage, and I confirm there are no mirage assets in the `app-name.js` yay!
but! @cah-brian-gantzler followup -- can we have an option to move everything, when included, in to the tests bundle?