ember.js icon indicating copy to clipboard operation
ember.js copied to clipboard

Remove `escapeExpression` from `@ember/template`

Open NullVoxPopuli opened this issue 1 year ago • 7 comments
trafficstars

Co-Authored-By: @chriskrycho

Rebase of: https://github.com/emberjs/ember.js/pull/20360

This also gets a mention here: https://github.com/emberjs/rfcs/pull/1003 :sweat_smile: (for migration docs)

NullVoxPopuli avatar Jan 22 '24 22:01 NullVoxPopuli

If it was private, shouldn't need to be in the RFC, I'd think

kategengler avatar Jan 22 '24 23:01 kategengler

May have been private but Handlebars.Utils.escapeExpression has uses in addons...

kategengler avatar Jan 22 '24 23:01 kategengler

May have been private but Handlebars.Utils.escapeExpression has uses in addons...

people using private apis should be used to what happens? :sweat_smile: :upside_down_face:

idk, what's the process here? do we need a deprecation in this case?

NullVoxPopuli avatar Jan 22 '24 23:01 NullVoxPopuli

Do they know it is private if it is hanging out on Ember.Handlebars.Utils.escapeExpression?

If it is truly private, we need an intimate API deprecation (1 LTS cycle), but if it is public, we need an RFC + full deprecation.

kategengler avatar Jan 22 '24 23:01 kategengler

I know ember-intl uses it as well.

bertdeblock avatar Jan 24 '24 13:01 bertdeblock

I've now rebased this PR, as I forgot about it :sweat_smile:

NullVoxPopuli avatar Jul 24 '24 13:07 NullVoxPopuli

Some test failures

kategengler avatar Jul 24 '24 14:07 kategengler