nora

Results 207 comments of nora

https://github.com/rust-lang/rust/issues/77733#issuecomment-706202542 mentions that this is a breaking change, because someone could implement `fmt::Write` and `io::Write` for their type and adding the blanket impl breaks this. So I don't think this...

Oh, I misread that, oops.

`From` should this be a generic? But I agree that `From` isn't very good for this

@ehuss it seems like people with expertise in atomics have given this a look by now. so I think it would just need an editorial review from you, which is...

This will also break everyone's builds using nighty if the feature ever changes. This is about a lint ans therefore purely internal, using it for everyone seems like a bad...

> I don't understand how it would break everyone's build on nightly, could you explain your reasoning please? I guess in this case here it won't, if the feature is...

`is_feature_flaggable` is harmful as well. Though it's probably more useful to not delete it but keep it and deprecate it saying "DONT DO THIS, use a feature flag". That will...

I also had a clippy lint trigger about `warning: unneeded late initalization` in an `XmlRead` derive. Style warnings should just be manually `allow`ed in the generated code in derive macros...

looks like rustfmt wasn't updated to print type ascription correctly, this issue should be removed to the rustfmt repo probably