Jiahao XU

Results 1312 comments of Jiahao XU

Hmmm, maybe run the script in a sub shell makes more sense? Not familiar with powershell enough but I guess if it's a shell it does support that?

I've found the official credential impl: - [libsecret for linux](https://docs.rs/cargo-credential-libsecret/0.5.0/cargo_credential_libsecret/struct.LibSecretCredential.html) - [mac keychain for mac](https://docs.rs/cargo-credential-macos-keychain/0.4.15/x86_64-apple-darwin/cargo_credential_macos_keychain/struct.MacKeychain.html#impl-Credential-for-UnsupportedCredential) - [windows credential for windows](https://docs.rs/cargo-credential-wincred/0.4.15/cargo_credential_wincred/struct.WindowsCredential.html) All of them are only available for their OS, so...

I'm a bit busy recently, so if you can open a PR, I'd be happy to take it.

Isn't there a plan for `cfg(version(""))`, once it is stablised and msrv bumped to it (maybe after 5 years), we won't need a build script? https://doc.rust-lang.org/beta/unstable-book/language-features/cfg-version.html

Good to hear at least serde can get rid of build script! > so removing the build script from serde_core doesn't seem very reasonable at this time Yeah...if `cfg(version(".."))` is...

https://github.com/ggbone1918/compress_timing/blob/b4d553b426980b82a05a96fcb4cf0a2dde3e1d4e/c/dictionary_compression.c#L46 your C code pre-allocates the buffer using the zstd hint the rust version just starts with an empty buffer

Not sure, maybe this one? https://docs.rs/zstd-safe/7.2.4/zstd_safe/fn.get_frame_content_size.html

Thank you for reporting! I would welcome any PR for this

Yee, if it is sending too many requests to GitLab it'd be rate limited If we uses its API, and scrap the token from local gitlab client/git-credential, then it'd be...