Jiahao XU
Jiahao XU
I agree that we should at least wait for weeks, at least until many has migrated to debian 13
> RHEL 8/9/10 only have 1.84 right now, but they'll be upgraded in the next minor release, around November. Thanks, it sounds good to wait until then
Todo - [ ] change max_by to max_by_key - [ ] use std::sync::OnceLock
looks like msrv 1.70 is more reasonable, it contains many stdlib API we want
I'm not planning to merge this PR right now, it's going to be months before it's merged
Yes we would probably bump msrv to 1.70 instead, in 6-12 months or even longer
Also, it's possible to remove the `copy_within` call completely, since we can just use `poll_write_vectored` call instead. While it is usually implemented using `poll_write`, it is still much better than...
For `poll_write` impl, we should try to flush internal buffer + write new data in one go, if says, half of the buffer is written with unflushed data
Though for `poll_..._buffer` we still want to get a whole buffer as long as possible...seems like we are recreating `bytes::BytesMut` Edit: We should probably have a rule based on the...
Thanks, we are definitely willing to support this!