Jiahao XU

Results 1312 comments of Jiahao XU

IMHO the windows implementation using named pipe, how do we know the exact name for the jobserver? Do we have to guess?

But there could be multiple client, and for windows you'd have one named pipe per token, so for each client, what is the name of the named pipe? It can't...

Thanks for the explanation! I'm not really familiar with Windows so I was confused by this, it'd be great if the doc explained that to people not familiar with Windows....

That looks pretty nice, looking forward to a rust implementation in rust-lang/jobserver-rs

I recommend qsv to have a `package.binstall` override so that it specifically uses the portable version, or maybe just put portable version as the default `qsv` and name the sse...

https://github.com/cargo-bins/cargo-binstall/blob/94a30bca2a2150531cbef343a0bba09db1dda2bb/crates/bin/src/logging.rs#L231 cargo-binstall uses [`supports_color::on`](https://docs.rs/supports-color/latest/supports_color/fn.on.html) to detect if basic color is supported, and enable color in tracing. Maybe we need to check for 256-bit color instead? P.S. it can be disabled...

Aha it could be related, maybe we have other colors used somewhere, let me check