Jiahao XU

Results 1312 comments of Jiahao XU

Hmmm...I wonder if other algorithm has the same behavior, or is that just gzip? for this PR, maybe we can make the behavior opt-in, if it is hard to implement...

Yeah, looking at the original issue seems like deno knows the body is empty before passing stuff to async-compression

Yeah it's a really good idea I didn't think of! Previous I only consider cargo-nextest if performance matters, I forgot that its process model would help isolate tests and would...

Yeah it's a really good idea I didn't think of! Previous I only consider cargo-nextest if performance matters, I forgot that its process model would help isolate tests and would...

Hmm does enabling [`Build::cpp`](https://docs.rs/cc/latest/cc/struct.Build.html#method.cpp) not working?

> It correctly identifies libc++ but the issue is that it fails to identify and link libc++abi which contains symbols for things such as exception handling. That's strange, based on...

Still not sure if aix needs cxxabi, because usually linking with libstdc++ or libcxx is suffice https://stackoverflow.com/questions/20357033/usr-lib-x86-64-linux-gnu-libstdc-so-6-version-cxxabi-1-3-8-not-found Maybe you didn't add cxxabi to LD_LIBRARY_PATH or it's not in the path...

Yeah filtering is good enough, rustc use linker-plugin-lto to ask linker to load llvm gold plugins to do cross lang LTO, since zig-cc is already LLVM it doesn't need it,...

I think this is mostly an API issue, since it doesn't add a lot of code we just want the right API

Does rustc has a minimum supported version for this? I think it might have for linking?