Nilstrieb

Results 88 comments of Nilstrieb

This has been fixed, we now run tests on post PGO artifacts. The optimized artifacts are tested before they are shipped.

> @Nilstrieb Out of curiosity, what kind of test would detect an improper packaging of a tool or a library? Compile hello world after extracting the tarball or something like...

> @m-ou-se @Nilstrieb @oli-obk @the8472 Assuming that AdaCore does all the implementation work on the RFC, what would it take to get the RFC accepted? We'd want the best solution...

let me regress binary size to test this

ugh, it does! `pull_request_target` does that.

i can open a new PR for just the first commit to merge

``` {"platform":"ubuntu-latest","reference":"350632","updated":"350632"} {"platform":"windows-latest","reference":"135168","updated":"135168"} ``` either I'm bad at regressing binary size or getting it from `stage0` doesn't quite work correctly and we really do need `stage0-sysroot` instead. I'm not very...

How does this interact with inlining? Isn't this entirely nonsensical if a function gets inlined? I'd a user expected to use `#[inline(never)]` strategically in the places they care about? Or...

See https://doc.rust-lang.org/reference/types/function-item.html#function-item-types