Nilstrieb comments

Results 88 comments of


Nilstrieb

Use `std::thread::ThreadId` instead of custom thread id

It makes the code a little simpler and avoids the need for having a custom thread_id module. But since it's a pretty simple module there isn't a huge benefit.

Use `std::thread::ThreadId` instead of custom thread id

Do you think we should do this? I'd resolve the conflicts then. If not, I can close it

Consistently use the highest bit of vector masks when converting to i1 vectors

Let's nominate it for the compiler meeting to find a reviewer.

Represent `Result<usize, Box<T>>` as ScalarPair(i64, ptr)

@bors try @rust-timer queue

Represent `Result<usize, Box<T>>` as ScalarPair(i64, ptr)

looks like noise and it being perf neutral to me

Mention Register Size in `#[warn(asm_sub_register)]`

though i dont think it really matters, in the end all PRs will be tested, no matter whether this one or a different one is first. if a PR wants...

cargo build crash

Thank you for the report. Are you able to reproduce the issue after `cargo clean`? Can you post the full error output, especially the start of the panic message? Additionally,...

Less generic code for Vec allocations

@bors try @rust-timer queue

Link `std` statically in `rustc_driver`

does this mean that external tools using rustc driver now also need to use this flag? would be nice if the duplicate std error message mentioned that. it would be...

std::rand: fix dragonflybsd after #121942.

It's okay to have breakage, but we'd of course rather have working targets. I think it's fine to wait a bit until the libc change is merged unless it's particularly...