backtrace-rs icon indicating copy to clipboard operation
backtrace-rs copied to clipboard

very good new binary size improvement

Open Noratrieb opened this issue 4 months ago • 8 comments

this significantly improves binary size, we need to merge this ASAP

Noratrieb avatar Mar 22 '24 21:03 Noratrieb

let me regress binary size to test this

Noratrieb avatar Mar 22 '24 21:03 Noratrieb

slightly concerned that this may not actually work unless the changeset is on master due to the jank way GHA works.

workingjubilee avatar Mar 22 '24 21:03 workingjubilee

ugh, it does! pull_request_target does that.

Noratrieb avatar Mar 22 '24 21:03 Noratrieb

i can open a new PR for just the first commit to merge

Noratrieb avatar Mar 22 '24 21:03 Noratrieb

yeah I am happy to optimistically merge that change.

workingjubilee avatar Mar 22 '24 22:03 workingjubilee

{"platform":"ubuntu-latest","reference":"350632","updated":"350632"}
{"platform":"windows-latest","reference":"135168","updated":"135168"}

either I'm bad at regressing binary size or getting it from stage0 doesn't quite work correctly and we really do need stage0-sysroot instead. I'm not very sure about that, who gets what from where when.

Noratrieb avatar Mar 22 '24 22:03 Noratrieb

@Kobzol whoops.

workingjubilee avatar Mar 22 '24 22:03 workingjubilee

I think that we need to use stage0-sysroot (but first, it needs to be fixed). stage0-sysroot isn't actually used almost anywhere, so that's probably the reason why this wasn't noticed.

Kobzol avatar Mar 23 '24 13:03 Kobzol