Niels Vanpachtenbeke
Niels Vanpachtenbeke
There are 2 South Africa PRs, but with different results it seems. Could you both verify which one is correct? https://github.com/spatie/holidays/pull/32
Thanks!
PR looks good! I'll wait for some approvals on the generated results before merging.
If applicable, I've added support for multi language: https://github.com/spatie/holidays/pull/177
No worries. Make sure your fork is in sync with this package: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/working-with-forks/syncing-a-fork You could always try a new branch from main and make a new PR
Thanks!
Could you verify if the dates are correct in the generated snapshot? At the moment the test is failing
I'm not aware of the situation in Colombia. I'll leave this PR open for other Colombians to discuss
PR looks good, thanks! If anyone else could verify the generated results, I'll merge the PR.