Niels Vanpachtenbeke
Niels Vanpachtenbeke
Aren't there any official Islamic holidays in Syria?
I merged a PR for Syria, but this one seems more advanced. Would you care to fix the merge conflicts?
Can you take a look at the failing tests & phpstan? Edit: you can run `composer analyse` locally for phpstan
PR looks good, thanks! I'm waiting on someone else to verify if the generated dates are correct!
In case you need multi language support: https://github.com/spatie/holidays?tab=readme-ov-file#getting-holidays-in-a-specific-language
Thanks!
Could you make sure all tests and phpstan are green? I think you removed one line too much
A few other PRs (https://github.com/spatie/holidays/pull/56) are working on Islamic holidays too. It might be useful to work together on this one. I would prefer a single implementation for those calculations...
PR looks good, thanks! I'll wait on some approval on the generated results before merging!