holidays icon indicating copy to clipboard operation
holidays copied to clipboard

Add United States Holidays

Open arcdigital opened this issue 1 year ago • 3 comments

I've added all US Bank holidays.

arcdigital avatar Jan 17 '24 17:01 arcdigital

@arcdigital I would maybe consider adding all of the "bank" holidays. Without all of the federal holidays where the banks are closed, we would be unable to use this (I work in the finance industry). Thanks for submitting!

mikedex avatar Jan 17 '24 18:01 mikedex

I've updated with all the bank holidays. The US is tricky but I think that makes the most sense.

arcdigital avatar Jan 17 '24 19:01 arcdigital

Sure I can do that, yes it is a newer holiday. I'll add that logic in.

arcdigital avatar Jan 19 '24 21:01 arcdigital

Just rebased it. I'll add the logic for Juneteenth.

arcdigital avatar Jan 23 '24 00:01 arcdigital

@Nielsvanpach should be good to go! rebased, added the logic for Juneteenth, and a second test.

arcdigital avatar Jan 23 '24 18:01 arcdigital

Thanks!

Nielsvanpach avatar Jan 24 '24 15:01 Nielsvanpach