holidays icon indicating copy to clipboard operation
holidays copied to clipboard

Add holidays for South Africa

Open pierredup opened this issue 1 year ago • 4 comments

pierredup avatar Jan 17 '24 19:01 pierredup

Thanks! Could you rebase on main, that way I can run the tests here

Nielsvanpach avatar Jan 18 '24 14:01 Nielsvanpach

There are 2 South Africa PRs, but with different results it seems. Could you both verify which one is correct? https://github.com/spatie/holidays/pull/32

Nielsvanpach avatar Jan 19 '24 21:01 Nielsvanpach

Both PRs looks to implement the same days. This one handles an additional edge case, where if a holiday rolls over from the Sunday to the Monday, it shouldn't be added if the Monday is already a Holiday (E.G if 25 Dec falls on a Sunday, it can't roll over to the Monday since the 26 Dec (the following Monday) will already be a holiday).

pierredup avatar Jan 20 '24 07:01 pierredup

Ah yes, the edge case that is covered here is indeed correct. This is the more complete implementation, and should be the one that gets merged. I'll close my PR :-)

P.S. I'll try to remember to open a PR once we know what our general election date will be, as that is very likely to be proclaimed a public holiday as well.

johanmeiring avatar Jan 20 '24 16:01 johanmeiring

Thanks!

Nielsvanpach avatar Jan 23 '24 13:01 Nielsvanpach