Naumel

Results 13 comments of Naumel

Is this conversation > I will follow and respond to the above implementation suggestions, or better ideas. concluded?

Hello, Thank you for your time and submitting changes, please review https://www.conventionalcommits.org/en/v1.0.0/#summary for conventions that apply to [pull request titles](https://github.com/aws/aws-cdk/blob/v1-main/CONTRIBUTING.md#step-4-pull-request).

Hello, I'd like to start by asking why do you have ephemeral credentials in `~/.aws/credentials`? Reference: https://docs.aws.amazon.com/cdk/v2/guide/getting_started.html#getting_started_prerequisites > Alternatively, you can set the environment variables AWS_ACCESS_KEY_ID, AWS_SECRET_ACCESS_KEY, and AWS_DEFAULT_REGION to...

Output: ``` @aws-cdk/aws-eks: /codebuild/output/src718486964/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-eks/lib/helm-chart.ts @aws-cdk/aws-eks: 54:53 error Trailing spaces not allowed no-trailing-spaces @aws-cdk/aws-eks: 55:15 error Trailing spaces not allowed no-trailing-spaces @aws-cdk/aws-eks: 57:30 error Trailing spaces not allowed no-trailing-spaces @aws-cdk/aws-eks: ✖...

Thank you for the time and submitting the change. You are missing the snapshot updates matching the integ test change: ``` @aws-cdk/aws-rds: CHANGED integ.proxy 2.827s @aws-cdk/aws-rds: Resources @aws-cdk/aws-rds: [~] AWS::RDS::DBInstance...

@Mergifyio update With regard to feedback: the build is failing. That needs to be fixed before all other steps.