aws-cdk icon indicating copy to clipboard operation
aws-cdk copied to clipboard

docs(aws-eks): clarify that nested helm chart values need to be provided as a nested dictionary

Open jameskelleher opened this issue 2 years ago • 7 comments


closes https://github.com/aws/aws-cdk/discussions/22013

Motivation: I spent a fair amount of time trying to figure out why values were not being passed when formatted using dot notation, i.e. { "webhook.port": 9443 }

All Submissions:

Adding new Unconventional Dependencies:

  • [ ] This PR adds new unconventional dependencies following the process described here

New Features

  • [ ] Have you added the new feature to an integration test?
    • [ ] Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

jameskelleher avatar Sep 20 '22 13:09 jameskelleher

gitpod-io[bot] avatar Sep 20 '22 13:09 gitpod-io[bot]

LGTM! Thanks for the callout in the doc.

pahud avatar Sep 20 '22 19:09 pahud

Thanks @pahud ! Would you be able to approve the PR as well?

jameskelleher avatar Sep 20 '22 22:09 jameskelleher

Hmmm why is CodeBuild failing? It doesn't look like I'm able to retry it

jameskelleher avatar Sep 21 '22 18:09 jameskelleher

Output:

@aws-cdk/aws-eks: /codebuild/output/src718486964/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-eks/lib/helm-chart.ts
@aws-cdk/aws-eks:   54:53  error  Trailing spaces not allowed  no-trailing-spaces
@aws-cdk/aws-eks:   55:15  error  Trailing spaces not allowed  no-trailing-spaces
@aws-cdk/aws-eks:   57:30  error  Trailing spaces not allowed  no-trailing-spaces
@aws-cdk/aws-eks: ✖ 3 problems (3 errors, 0 warnings)
@aws-cdk/aws-eks:   3 errors and 0 warnings potentially fixable with the `--fix` option.

Naumel avatar Sep 22 '22 15:09 Naumel

@Naumel How embarrassing! I'll get that fixed up now. Thanks for highlighting that for me.

jameskelleher avatar Sep 22 '22 21:09 jameskelleher

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 773f3b8fac61f9827c8584fe8875a2787783794d
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation avatar Sep 22 '22 21:09 aws-cdk-automation

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify[bot] avatar Sep 23 '22 06:09 mergify[bot]