aws-cdk
aws-cdk copied to clipboard
docs(aws-eks): clarify that nested helm chart values need to be provided as a nested dictionary
closes https://github.com/aws/aws-cdk/discussions/22013
Motivation: I spent a fair amount of time trying to figure out why values were not being passed when formatted using dot notation, i.e. { "webhook.port": 9443 }
All Submissions:
- [x ] Have you followed the guidelines in our Contributing guide?
Adding new Unconventional Dependencies:
- [ ] This PR adds new unconventional dependencies following the process described here
New Features
- [ ] Have you added the new feature to an integration test?
- [ ] Did you use
yarn integ
to deploy the infrastructure and generate the snapshot (i.e.yarn integ
without--dry-run
)?
- [ ] Did you use
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license
LGTM! Thanks for the callout in the doc.
Thanks @pahud ! Would you be able to approve the PR as well?
Hmmm why is CodeBuild failing? It doesn't look like I'm able to retry it
Output:
@aws-cdk/aws-eks: /codebuild/output/src718486964/src/github.com/aws/aws-cdk/packages/@aws-cdk/aws-eks/lib/helm-chart.ts
@aws-cdk/aws-eks: 54:53 error Trailing spaces not allowed no-trailing-spaces
@aws-cdk/aws-eks: 55:15 error Trailing spaces not allowed no-trailing-spaces
@aws-cdk/aws-eks: 57:30 error Trailing spaces not allowed no-trailing-spaces
@aws-cdk/aws-eks: ✖ 3 problems (3 errors, 0 warnings)
@aws-cdk/aws-eks: 3 errors and 0 warnings potentially fixable with the `--fix` option.
@Naumel How embarrassing! I'll get that fixed up now. Thanks for highlighting that for me.
AWS CodeBuild CI Report
- CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
- Commit ID: 773f3b8fac61f9827c8584fe8875a2787783794d
- Result: SUCCEEDED
- Build Logs (available for 30 days)
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).