aws-cdk icon indicating copy to clipboard operation
aws-cdk copied to clipboard

fix(aws-s3): Add validation for transitions in lifecycleRules

Open Damon1024 opened this issue 3 years ago • 5 comments

Closes: #22103

Added validation for S3 bucket transition lifecycleRules


All Submissions:

Adding new Unconventional Dependencies:

  • [ ] This PR adds new unconventional dependencies following the process described here

New Features

  • [ ] Have you added the new feature to an integration test?
    • [ ] Did you use yarn integ to deploy the infrastructure and generate the snapshot (i.e. yarn integ without --dry-run)?

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Damon1024 avatar Sep 19 '22 07:09 Damon1024

gitpod-io[bot] avatar Sep 19 '22 07:09 gitpod-io[bot]

Hello,

Thank you for your time and submitting changes, please review https://www.conventionalcommits.org/en/v1.0.0/#summary for conventions that apply to pull request titles.

Naumel avatar Sep 19 '22 10:09 Naumel

@Mergifyio update

Naumel avatar Sep 19 '22 11:09 Naumel

update

✅ Branch has been successfully updated

mergify[bot] avatar Sep 19 '22 11:09 mergify[bot]

@Mergifyio update

TheRealAmazonKendra avatar Oct 02 '22 06:10 TheRealAmazonKendra

update

✅ Branch has been successfully updated

mergify[bot] avatar Oct 02 '22 06:10 mergify[bot]

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e99ed05e7d5bc7b6659009390822b8b3e75314b5
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

aws-cdk-automation avatar Oct 02 '22 07:10 aws-cdk-automation

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

aws-cdk-automation avatar Oct 24 '22 00:10 aws-cdk-automation

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

aws-cdk-automation avatar Oct 31 '22 18:10 aws-cdk-automation

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

aws-cdk-automation avatar Oct 31 '22 18:10 aws-cdk-automation