Nathan Daly

Thanks @timholy! Sorry for my delay (-- among other things, I got married! 🎉) :) Awesome! Moving to JuliaDebug sounds great. 👍 +1 to that. Yeah, I definitely defer to...

Yeah, interesting. I _have_ usually thought of show has having the same contract as `repr`, because the julia implementation of `repr(x)` calls `show(::IO, x)`! My understanding is that it _is_...

This actually also leads to the fact that operators can throw InexactErrors, while promoting the other arguments: ```julia julia> FixedDecimal{Int8,2}(1) + 2 # 2 is promoted to FD{Int8,2}(2), which doesn't...

@TotalVerb I originally added the straightforward method, below, but it gave a MethodAmbiguity error: ```julia julia> Base.rem(x::T, y::T, r::RoundingMode) where {T rem(x, x, RoundUp) ERROR: MethodError: rem(::FixedDecimal{Int64,2}, ::FixedDecimal{Int64,2}, ::RoundingMode{:Up}) is...

Additionally, one other concern: The default 3-arg `Base.rem` implementation provided above doesn't call `promote` like the 2-arg versions do, which means that our newly added methods aren't being triggered for...

> If the `# TODO` resolves in Base, then we will need to implement something like this PR, but until then I suppose it is not needed. Okay yeah, makes...

Hmm, yeah i'm ambivalent. I guess accepting whitespace is also what C++'s parsing functions do as well (`io >> x`). Given the julia behavior i'd say we should just do...

@omus that PkgBenchmark seems nice, thanks for the link. (I'm sending a couple PRs now to clean it up for 1.0 so we can tag a version there. 😄) I...

Okay! I think i've got the benchmarks working via `PkgBenchmark.jl`, based on https://github.com/JuliaCI/PkgBenchmark.jl/pull/75 going through. (I added a Project.toml pointing at that branch for now, so that we can demo...

# Benchmark Report for *FixedPointDecimals* ## Job Properties * Time of benchmark: 20 Dec 2018 - 13:15 * Package commit: 0dbf53 * Julia commit: d78923 * Julia command flags: None...