Gino Valente

Results 207 comments of Gino Valente

### Considerations To give further details on the alternatives, here's a quick summary of some of the considerations to be made: 1. The error state. _How do we handle a...

I think I'm going to switch `SceneFilter::Allowlist` and `SceneFilter::Denylist` to take their own structs instead of `HashSet` directly. My thought being that we may want to change the implementation or...

> I think I'm going to switch `SceneFilter::Allowlist` and `SceneFilter::Denylist` to take their own structs instead of `HashSet` directly. My thought being that we may want to change the implementation...

> I can't seem to understand the point about the tradeoff though. If the extraction is moved on `build`, why does the entity iterator need to be iterated twice? I'm...

> ### Move extract_entity behavior to build() > I actually think that allowing this ordering to have meaning is a feature not a bug. There could be times when within...

I think we'll leave off the default type filtering for now. A lot of the types we might want to filter are in crates that aren't dependencies of `bevy_scene`. We...

> * adding a separate example for filtering makes the most sense to me: I find having examples for specific features more clear than putting too much information into a...

> @MrGVSV are you able to rebase and complete this? I'd like to move this forward, but the conflicts are non-trivial and the suggestions are good :) Sure thing! I'll...

Rebased and updated to include changes from #6846 that allowed resources to be included in scenes. This meant the following methods were added: - `DynamicSceneBuilder::with_resource_filter` - `DynamicSceneBuilder::allow_resource` - `DynamicSceneBuilder::deny_resource` -...

> It feels like this issue would be fixed by #5781 and adding methods to create a register from an existing one. Would this PR still has an advantage if...