Sean Marciniak
Sean Marciniak
Sorry @jerrytfleung , I am going to ask you to fix up the conflicts if you don't mind.
Hey @edmocosta, > it is still required for compatibility purposes Do you mind explaining what specifically you need to support for compatibility purposes? My preference is to keep this as...
Mmm, that is interest on the memory spike. It would be awesome if you're able to grab some pprof samples to help paint a bigger picture of what happened. I...
It looks like the issue is upstream from what I can tell, specifically [this line](https://github.com/Shopify/sarama/blob/9127f1c432c08b9a766fdb0931bfd0da80dddde0/async_producer.go#L453) The issue being is if you have a message size of , 1_000_000 bytes (1MB),...
The kafka docs aren't really forth coming on what the comparison should be looking at https://kafka.apache.org/documentation/#topicconfigs_max.message.bytes. If you don't mind doing an experiment on my behalf, could you set: ```yaml...
> This has been approved for 2 weeks. Can it merge? Can I ask you to fix up the merge conflicts please?
Can I ask you to fix up the conflicts?
> Hey @TylerHelmuth @evan-bradley would you please have a look? Just doubling checking with code owners before it is merged.
Hey @evan-bradley, just double checking you're okay with the changes made?
Would it be possible to squash some of these commits? Hopefully it should make any branch updates easier :)