Sean Marciniak comments

Results 84 comments of


                                            Sean Marciniak

chore: Moves internal/kafka To pkg/kafka

Could I ask you to fix up the conflicts? Once that is done I can get the builds running again :)

[receiver/kafkareceiver] Add settings to Kafka Receiver for group management facilities

Hey @strawgate , Can I ask you to fix up the unit tests?

[receiver/kafkareceiver] Add settings to Kafka Receiver for group management facilities

> Yes will tackle soon, sorry i didn't catch that earlier Can I ask you to ping me once you have a chance to fix?

[servicegraphconnector]fix wrong latency

Hey @zhangtong007 , Do you mind fixing up the typo before we go ahead and merge this?

[servicegraphconnector]fix wrong latency

Just a reminder ping on this @zhangtong007 :)

[exporter/signalfx] Fix goroutine leaks

@crobert-1 can I ask you to fix the merge conflicts?

[chore] move dockerstats receiver's objects to package internal/docker/receiver

> While I partially agree, I'd like to make it clear whether this is the way it should be done, as purely transform `dockerstats` receiver into `docker` receiver is already...

[kafka/internal, kafkaexporter, kafkareceiver] Add SASL mechanism "AWS_MSK_IAM_OAUTHBEARER" to kafkaexporter

> @MovieStoreGuy PTAL and let me know if there is anything to follow up. Thank you. Sorry it has taken me a bit, there is only one outstanding nit from...

[Proposal] Add an additional APAC collector/agent SIG

With those proposed times, I am able to attend both the NA-APAC and EU-APAC. Thank you @mx-psi for following up on this

New component observer/cfgardenobserver

> sorry to any maintainers that got pinged, messed up a rebase No dramas, happens from time to time :)