Sean Marciniak

Results 84 comments of Sean Marciniak

I am to start simple and make it more complex as we need :) I was thinking that a user could configure a `keyby` by using some combination of `name`,...

Sorry I am late coming to this, but I agree with @tigrannajaryan

I think you want to use `assert.EqualValues` instead of `assert.Exactly` since I suspect it is trying to enforce the same pointer address.

> @MovieStoreGuy Found the problem. Because the +Inf bucket has a value of NaN I can't compare them because NaN == NaN is false. I made the test explicitly test...

I think it is fair enough to say that we carry on with using the change log and using tagged commits @tiedotguy

Not sure on the impact if you upgrade the either the client or server. This will also require rebuilding the protobuf bindings with protoc

I believe so, haven't looked into enough to fully understand the implications.

Moving Releases to own Pull Request since that this draft is big

Forwarder to flush all metrics within a time interval is done here https://github.com/atlassian/gostatsd/pull/422/files