opentelemetry-collector-contrib icon indicating copy to clipboard operation
opentelemetry-collector-contrib copied to clipboard
verified publisher icon open-telemetry

OTel-Arrow exporter timeout propagation

Open jmacd opened this issue 1 year ago • 1 comments

Description: Exporter side of https://github.com/open-telemetry/otel-arrow/issues/227. The receiver side is https://github.com/open-telemetry/opentelemetry-collector-contrib/pull/34742.

Link to tracking Issue: https://github.com/open-telemetry/otel-arrow/issues/227

Testing: Adds a test for the expected metadata propagation.

Documentation: Since this is expected of gRPC receivers, no docs are changed.

jmacd avatar Aug 19 '24 16:08 jmacd

This has been approved for 2 weeks. Can it merge?

jmacd avatar Aug 30 '24 15:08 jmacd

This has been approved for 2 weeks. Can it merge?

Can I ask you to fix up the merge conflicts please?

MovieStoreGuy avatar Sep 04 '24 00:09 MovieStoreGuy

Can I ask you to fix up the merge conflicts please?

Of course! I fix the conflicts after every release, but this has been sitting for two release cycles and now I'll have to fix them twice.

jmacd avatar Sep 04 '24 14:09 jmacd

@songy23 Thank you. I appreciate your help. The linter changed while this PR was open,.

I want to point out that this PR was approved and green following commit f735180 and again following commit 9e4d8e3. It takes a relatively large amount of work to keep these PRs green, and this is the third time. Please merge!

jmacd avatar Sep 05 '24 14:09 jmacd