Moshe Atlow
Moshe Atlow
I would say there are two separate issues raised here: 1. watching paths/files that are not required, which is currently supported with [`--watch-path`](https://nodejs.org/dist/latest-v18.x/docs/api/cli.html#--watch-path) 2. using globs as an input for...
Refs: https://github.com/nodejs/node/issues/40731
well this is an example of a failure: ``` 02:35:52 # Subtest: test-runner/output/dot_output_custom_columns.js 02:35:52 not ok 42 - test-runner/output/dot_output_custom_columns.js 02:35:52 --- 02:35:52 duration_ms: 265.745104 02:35:52 location: '/home/iojs/build/workspace/node-test-commit-arm/test/parallel/test-runner-output.mjs:156:5' 02:35:52 failureType: 'testCodeFailure'...
Landed in 8536b674d842
> I'm not sure if this is semver-minor / notable-change I think both :)
Sorry for the delay in the response. this sounds like a great idea, but I am not sure it should be on by default. we might want to make it...
using an existing solution makes sense to me, but if a reimplementation will make code look better then I am ok with that as well
This should land only if there are other tests that ensures colors work as expected
btw it seems the artifacts did partially upload, https://r2.nodejs.org/dist/v18.18.1/, https://r2.nodejs.org/docs/latest-v18.x/api/ and https://r2.nodejs.org/docs/latest-hydrogen/api/ are updated but https://r2.nodejs.org/dist/latest-v18.x/ and https://r2.nodejs.org/dist/latest-hydrogen/ are not
> Are those separate uploads or are those latest-* directories supposed to be handled by [nodejs/release-cloudflare-worker](https://github.com/nodejs/release-cloudflare-worker)? I see https://github.com/nodejs/release-cloudflare-worker/pull/47 has updated the JSON to point at 18.18.1. yes, as @flakey5...