Moshe Atlow

Results 213 comments of Moshe Atlow

> Did you check if the stage 2 proposal requires one way or another? I think it's quite important that our implementation matches the proposal. the [section about concurrency](https://github.com/tc39/proposal-async-iterator-helpers#concurrency) doesn't...

> It flattens everything and applies concurrency on the flat stream of entries. that is not the current behavior. it currently applies concurrency on getting/creating an iterator from the mapping...

Also worth running on a windows machine before landing

Triggered https://ci.nodejs.org/job/node-test-linter/54577/console and it failed :( ``` 20:19:04 Running JS linter... 20:19:04 20:19:04 Oops! Something went wrong! :( 20:19:04 20:19:04 ESLint: 9.2.0 20:19:04 20:19:04 ConfigError: Config (unnamed): Key "rules": Key...

can you give an example of your use case? do you mean something along the lines of `path.matchesPattern(pattern:string, path:string) => boolean`?

@RedYetiDev are you interested in picking this up and adding a `path.isMatch`/`path.matchesPattern` helper?

I am -1 on adding this to node as it is an anti-pattern, and it can be achieved with a few lines of code, or a npm package

> Why is it considered an anti pattern? since it is mostly abused by encouraging tests to be non-deterministic and non-predictable (in the majority of cases i've seen). such features...

please also resolve conflicts

the failures look unrelated, re-running