Antonin Décimo
Antonin Décimo
I could not reproduce. I built an OCaml 4.14 compiler using the 4.14 branch and the Cygwin port, which I used to build opam 2.2.1, then built a OCaml 5.3...
Indeed, I can reproduce by running the tests.
The post-install message could also advise to install ocp-index. This would prevent an error later raised: > Error: Completion and doc lookup needs ocp-index. Try 'opam install ocp-index'.
Prior discussion on the pros and cons of errorcheck mutexes for OCaml 4 can be found at #9757 and #9846. I even considered merging the errorcheck patch into _Implement concurrency...
> > > It would be great if this PR could be considered for inclusion in 5.3 > > > > I'm afraid that ship has sailed :) 5.3 is...
> I need to be convinced this is not a regression compared to just using winpthreads, or a more modern implementation of the POSIX API for Win32. There are benefits...
I've looked at some other languages runtime and standard libraries. I found some C code for Golang that's clearly using the WinAPI, and the Linux equivalent is using pthreads. https://github.com/golang/go/blob/master/src/runtime/cgo/gcc_libinit_windows.c...
Rebased after the end of the cleanup-at-exit effort with #12964.
Thanks for looking at this @eutro! In the meantime, I've rebased this PR and split out the part introducing `caml_plat_thread` and `caml_plat_thread_attr` to its own commit, to help reviewing.
It is awaiting more reviews from wizards. @dustanddreams and @shym reviewed an early version, but I don't think it counts anymore as a an approval. @eutro reviewed this code somewhat...