Antonin Décimo
Antonin Décimo
I'll submit a patch to Lwt for 1, which seems more sensible to me.
There's a third option, which is simply to change the namespace and provide `lwt_convert_flag_list` wrapping `caml_convert_flag_list`.
`_Noreturn` is deprecated in C23, which GCC 15 and the upcoming clang will default to. I haven't tested if they warn about it, or what we're to expect in term...
Thanks for the explanations. The PR looks good to me, all the changes make sense to me on their own and taken together.
I'm not sure where we're at right now with this PR, but getting the reason, the motive, the cause, of why a test is skipped would be super helpful.
> I don't think you should modify the `Http.Request.t` type. The point of this type is to stay minimal and not reflect any application specific concerns. We're only adding a...
> EDIT: after glancing at the spec, seems like 1. is the way to go. the `resource` field should already handle requests in "absolute form" I did not follow this...
> @MisterDA do you want to take the honors of getting rid of it? It doesn't seem possible to remove the `scheme` field of the request, as `Cohttp.Request.uri` needs to...
The CI errors will be fixed when core_unix 0.18 is released.
Is it just missing in `caml/domain_state.h` an `extern "C"` block to prevent C++ name mangling? ```c #ifdef __cplusplus extern "C" { #endif /* … */ #ifdef __cplusplus } #endif ```