Antonin Décimo
Antonin Décimo
pinging the usual suspect(s)—@nojb does this make sense to you?
Thanks for the review, I've rebased it on the current trunk.
> Would it be possible to call `Filename.temp_file_name` (which uses a per-domain PRNG key) to avoid name collisions? I see that you are trying to do this from C, but...
Rather than a callback, which feels tricky to use when combining retries and releasing/acquiring the runtime system, I've chosen to create and pass the path to the socket from the...
We could apply the `run-crosscompiler-tests` label to this PR.
THank you both for your input! > What's the use-case for `FLEXLINKFLAGS`? I have experimental patches to swap the linker: I can replace the default `ld` and `link` with `ld.lld`...
I've rebased the PR. I think it looks good to me too.
We could also check the `CPPFLAGS` variable for flags specific to the C/C++ preprocessor. It is (at least) understood by [GNU Make](https://www.gnu.org/software/make/manual/html_node/Implicit-Variables.html#index-CPPFLAGS).
> Should we add `LDFLAGS` as well? Yes! Looking for inspiration, Arch Linux' [makepkg](https://wiki.archlinux.org/title/Makepkg) (the program used to build custom packages) allows user to set `CPPFLAGS`, `CFLAGS`, `CXXFLAGS`, and `LDFLAGS`...
I thought that buildkit syntax was enabled on the deployer, apparently it's not? You could try adding that as the first line of the Dockerfile: ```dockerfile # syntax=docker/dockerfile:1 ``` EDIT:...