Antonin Décimo

Results 287 comments of Antonin Décimo

I'm convinced that _adding a prototype_ of the tested function to the example program is better and more portable than passing the extra warning flag. We should rather alter the...

Yes, it's great, I'm just thinking we can go further. The OCaml 4.02 package hasn't been deprecated, for instance, so it's still shown.

It's just that having these old packages in the middle of the options, system, arch, and ocaml-variants packages is a bit annoying. What's more is that the lines and descriptions...

``` _=/usr/bin/env ALLUSERSPROFILE=C:\ProgramData APPDATA=C:\Users\User\AppData\Roaming CAML_LD_LIBRARY_PATH=C:\Users\User\AppData\Local\opam\ocaml.5.2\lib\stublibs CommonProgramFiles(x86)=C:\Program Files (x86)\Common Files COMMONPROGRAMFILES=C:\Program Files\Common Files CommonProgramW6432=C:\Program Files\Common Files COMSPEC=C:\WINDOWS\system32\cmd.exe CYGWIN=winsymlinks:native DriverData=C:\Windows\System32\Drivers\DriverData HOME=/cygdrive/c/Users/User HOMEDRIVE=C: HOMEPATH=\Users\User INFOPATH=/usr/local/info:/usr/share/info:/usr/info LANG=en_US.UTF-8 LOCALAPPDATA=C:\Users\User\AppData\Local MAKEFLAGS=-j12 MANPATH=:/cygdrive/c/Users/User/AppData/Local/opam/ocaml.5.2/man MSYS=winsymlinks:native OCAML_TOPLEVEL_PATH= OCAMLTOP_INCLUDE_PATH=C:\Users\User\AppData\Local\opam\default\lib\toplevel: OPAM_LAST_ENV=C:\Users\User\AppData\Local\opam\.last-env\env-d567f03af7597e56edca4619015a2b5b-0...

I also have this problem with MSVC and the ocaml 5.3.0 package: ``` [ERROR] The compilation of ocaml.5.3.0 failed at "ocaml C:\\Users\\Antonin\\AppData\\Local\\opam\\msvc\\share\\ocaml-config/gen_ocaml_config.ml 5.3.0 ocaml". #=== ERROR while compiling ocaml.5.3.0 ========================================#...

Note that as the `install` rule depends on `all` and `$(SOEXTVER)`, `$CC` needs to be set (or correctly discovered) when running `make install`, which is a bit unusual. ~Also, I...

gentle ping @ObserverOfTime @maxbrunsfeld

I agree that CMake is superior here, but I'm contributing to a lengthy build process where it's not used and I'm reluctant to introduce it. I think these are overall...

Please consider merging this, or revert my #4201, which is incomplete and fixed by this PR.

The problem is that `lwt_unix.h` defines this for compatibility: ```c #if OCAML_VERSION < 50000 #define caml_convert_flag_list(flags, table) \ caml_convert_flag_list((flags), (int *)(table)) #endif ``` the real function is defined in `caml/alloc.h`,...